fix(GraphQL): Remove github issues link from the error messages. #6036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
pawanrawal
changed the title
pawanrawal
changed the title
abhimanyusinghgaur
suggested changes
Jul 21, 2020
There was a problem hiding this comment.
There is one ErrGraphQLSchemaAlterFailed in worker/graphql_schema.go which uses similar template. That also needs to be changed.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @MichaelJCompton)
abhimanyusinghgaur
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)
gja
pushed a commit
that referenced
this pull request
Jul 31, 2020
Since we don't use GitHub issues anymore, error messages should not link to them. Updating the error messages to say so.
JatinDev543
pushed a commit
that referenced
this pull request
Aug 13, 2020
Since we don't use GitHub issues anymore, error messages should not link to them. Updating the error messages to say so.
JatinDev543
added a commit
that referenced
this pull request
Aug 14, 2020
…) (#6183) Since we don't use GitHub issues anymore, error messages should not link to them. Updating the error messages to say so. Co-authored-by: Pawan Rawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't use GitHub issues anymore, error messages should not link to them. Updating the error messages to say so.
This change is
Docs Preview: