Add graceful shutdown logic for WebSocket #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lmlmt PTAL, thx. |
JmPotato
force-pushed
the
add_stop_websocket
branch
3 times, most recently
from
21ffe71 to
c59c47c
Compare
lmlmt
requested changes
Dec 5, 2024
lmlmt
reviewed
Dec 5, 2024
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
add_stop_websocket
branch
from
c59c47c to
88c71f2
Compare
|
@lmlmt Addressed the comments, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, if the WebSocket client is created, the program cannot be shut down until the key interruption occurs due to the keepalive thread. This PR adds the graceful shutdown logic for WebSocket client within
Info.Close #24.
Call
disconnect_websocket()whenskip_ws=True: