Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iroha_config): broken trusted peers check #5121

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix(iroha_config): broken trusted peers check #5121

merged 1 commit into from
Oct 8, 2024

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Oct 4, 2024

Context

Split from #5087

When there was one trusted peer, it decided that there are no.

Solution

Fix the check

Migration Guide (optional)

None

Review notes (optional)

None

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@0x009922 0x009922 added Bug Something isn't working Chore This is a small task that can be done at any point in time and is easier than others labels Oct 4, 2024
@0x009922 0x009922 self-assigned this Oct 4, 2024
@0x009922 0x009922 mentioned this pull request Oct 4, 2024
Merged
8 tasks
@s8sato s8sato self-assigned this Oct 7, 2024
@mversic
Copy link
Contributor

mversic commented Oct 7, 2024

there seem to be a test failing

@0x009922
Copy link
Contributor Author

0x009922 commented Oct 8, 2024

there seem to be a test failing

Yup, flaky unrelated test (integration::triggers::by_call_trigger::unregistering_one_of_two_triggers_with_identical_wasm_should_not_cause_original_wasm_loss)

@0x009922 0x009922 force-pushed the fix/config-trusted-peers-check branch from 41c155d to e43db16 Compare October 8, 2024 05:12
@0x009922 0x009922 enabled auto-merge (squash) October 8, 2024 05:12
@0x009922 0x009922 merged commit 0059c39 into hyperledger:main Oct 8, 2024
11 checks passed
@alexstroke1 alexstroke1 self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DCNick3 DCNick3 DCNick3 approved these changes

@s8sato s8sato s8sato approved these changes

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@DCNick3 DCNick3

@0x009922 0x009922

@s8sato s8sato

@alexstroke1 alexstroke1

Labels
Bug Something isn't working Chore This is a small task that can be done at any point in time and is easier than others
Projects
Iroha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0x009922 @mversic @DCNick3 @s8sato @alexstroke1