refactor!: revert _ms and _bytes suffixes in config
#4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
added
config-changes
0x009922
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
DCNick3,
VAmuzing and
dima74
as code owners
nxsaken
previously approved these changes
May 30, 2024
|
CI failed due to a single I made this rule a warning locally. And, I don't think it should be a hard error in general. Warning is just fine in all circumstances. |
nxsaken
previously approved these changes
May 30, 2024
nxsaken
previously approved these changes
May 30, 2024
0x009922
force-pushed
the
fix-human-non-human-config-types
branch
3 times, most recently
from
14cffe8
to
9a1f880
Compare
VAmuzing
previously approved these changes
Jun 2, 2024
0x009922
force-pushed
the
fix-human-non-human-config-types
branch
2 times, most recently
from
631c704
to
89306c7
Compare
nxsaken
force-pushed
the
fix-human-non-human-config-types
branch
from
89306c7
to
4234725
Compare
nxsaken
previously approved these changes
Jun 10, 2024
mversic
requested changes
Jun 10, 2024
0x009922
force-pushed
the
fix-human-non-human-config-types
branch
from
4234725
to
d224e9d
Compare
nxsaken
requested changes
Jun 11, 2024
mversic
previously approved these changes
Jun 11, 2024
nxsaken
previously approved these changes
Jun 11, 2024
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
0x009922
force-pushed
the
fix-human-non-human-config-types
branch
from
d224e9d
to
4dc45ea
Compare
mversic
approved these changes
Jun 14, 2024
nxsaken
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since there is still no consensus about using human readable types in configuration (#4294, #4295), I decided to at least make it explicit that they aren't supported.
_mssuffix for millisecond numbers_bytessuffix fortorii.max_content_length_bytesHumanDurationtoDurationMs, andHumanBytesto justBytes