Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4290: Replace parse_display crate with strum #4401

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Apr 2, 2024

Description

Remove the parse_display dependency since strum provides the needed derives.

Linked issue

Closes #4290.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@nxsaken nxsaken added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Apr 2, 2024
@nxsaken nxsaken self-assigned this Apr 2, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8522063196

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 5321 unchanged lines in 95 files lost coverage.
  • Overall coverage increased (+0.9%) to 57.682%

Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
crypto/src/hash.rs 1 73.78%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/must_use.rs 2 74.29%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
Totals Coverage Status
Change from base Build 7884695009: 0.9%
Covered Lines: 23488
Relevant Lines: 40720

💛 - Coveralls

@nxsaken
Copy link
Contributor Author

nxsaken commented Apr 3, 2024

Is this OK to merge? The failing CI checks seem to be unrelated to the changes, but I might be missing some nuance here.

@Erigara
Copy link
Contributor

Erigara commented Apr 3, 2024

It’s ok, fails are unrelated

@nxsaken nxsaken merged commit 172769c into hyperledger:iroha2-dev Apr 3, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants