Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with_coverage #4488

Closed
mversic opened this issue Apr 22, 2024 · 2 comments · Fixed by #4573
Closed

Fix with_coverage #4488

mversic opened this issue Apr 22, 2024 · 2 comments · Fixed by #4573
Assignees
@0x009922 @s8sato @BAStos525
Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Apr 22, 2024

After merging #4414 with_coverage is failing
@mversic mversic added CI iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 22, 2024
@AlexStroke
Copy link
Contributor

AlexStroke commented Apr 23, 2024 •
edited
Loading

telegram-cloud-photo-size-2-5381943039976656869-y
FYI This is 6th February 2024 report using the new grcov tool from Vasiliy

s8sato added a commit to s8sato/iroha that referenced this issue Apr 24, 2024
@s8sato
wip attempt to fix hyperledger#4488
2d2463a 
Signed-off-by: Shunkichi Sato <[email protected]>
@mversic mversic mentioned this issue Apr 24, 2024
Merged
5 tasks
@mversic mversic added this to the 2.0.0-rc.1 milestone Apr 24, 2024
@mversic mversic removed this from the 2.0.0-rc.1.0 milestone May 6, 2024
s8sato added a commit to s8sato/iroha that referenced this issue May 9, 2024
@s8sato
ci: by command, exclude client integration tests from coverage
cd95293 
closes issue hyperledger#4488

Signed-off-by: Shunkichi Sato <[email protected]>
@s8sato s8sato mentioned this issue May 9, 2024
Merged
5 tasks
@s8sato
Copy link
Contributor

s8sato commented May 9, 2024

As of 2cf50c0 I2::Dev::Tests / with_coverage is failing due to -p iroha_client --test mod (client/tests/integration/). It seems to happen with the following combination:

  • nightly-2024-04-18
  • RUSTFLAGS="-C instrument-coverage"
  • -p iroha_client --test mod
    • not filtered out, because #[cfg(not(coverage))] is allowed by cargo-llvm-cov and does not work with grcov

I don't know the exact cause, but we can work around this. Just exclude the client integration tests in command without attributes

s8sato added a commit to s8sato/iroha that referenced this issue May 10, 2024
@s8sato
ci: redefine with_coverage step to exclude client integration tests
5f3e760 
closes issue hyperledger#4488

Signed-off-by: Shunkichi Sato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x009922 0x009922

@s8sato s8sato

@BAStos525 BAStos525

Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix with_coverage, isolate not unstable but extra_functional s8sato/iroha
5 participants
@0x009922 @mversic @s8sato @BAStos525 @AlexStroke