Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actualise Dockerfiles with the new config system #4292

Closed
0x009922 opened this issue Feb 18, 2024 · 0 comments
Closed

Actualise Dockerfiles with the new config system #4292

0x009922 opened this issue Feb 18, 2024 · 0 comments
Assignees
@0x009922 @alexstroke1
Labels
CI config-changes Changes in configuration and start up of the Iroha iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

#4239 left something unfinished. This time it is about the Dockerfiles:

iroha/Dockerfile

Lines 44 to 47 in 9644767

# FIXME: these are obsolete
ENV IROHA2_CONFIG_PATH=$CONFIG_DIR/config.json
ENV IROHA2_GENESIS_PATH=$CONFIG_DIR/genesis.json
ENV KURA_BLOCK_STORE_PATH=$STORAGE

iroha/Dockerfile.glibc

Lines 33 to 35 in 39fb088

ENV IROHA2_CONFIG_PATH=$CONFIG_DIR/config.json
ENV IROHA2_GENESIS_PATH=$CONFIG_DIR/genesis.json
ENV KURA_BLOCK_STORE_PATH=$STORAGE

This issue is not only about the ENV vars. It is more about reconsidering the approach itself of how Iroha is configured in context of Docker.
@0x009922 0x009922 added iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha CI labels Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Closed
@0x009922 0x009922 self-assigned this Mar 14, 2024
@0x009922 0x009922 mentioned this issue Mar 14, 2024
Merged
0x009922 added a commit that referenced this issue Mar 19, 2024
@0x009922
[fix] #4292, #4327: Docker follow-up on configuration update (#4367)
ac872b2 
* [fix]: implement reading of `SUMERAGI_TRUSTED_PEERS`

Signed-off-by: Dmitry Balashov <[email protected]>

* [build]: update Dockerfile(s)

Signed-off-by: Dmitry Balashov <[email protected]>

* [build]: revert `CONFIG_DIR`

Signed-off-by: Dmitry Balashov <[email protected]>

---------

Signed-off-by: Dmitry Balashov <[email protected]>
@AlexStroke AlexStroke self-assigned this Mar 26, 2024
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x009922 0x009922

@alexstroke1 alexstroke1

Labels
CI config-changes Changes in configuration and start up of the Iroha iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0x009922 @AlexStroke @alexstroke1