Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration of accounts without signatories #4212

Closed
mversic opened this issue Jan 18, 2024 · 0 comments
Closed

Registration of accounts without signatories #4212

mversic opened this issue Jan 18, 2024 · 0 comments
Assignees
@Arjentix @alexstroke1
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Jan 18, 2024

Currently we seem to allow this, but we don't allow burning the last signatory of an account (we have a test ensuring this public_keys_cannot_be_burned_to_nothing). Should we also prevent creation of Account/NewAccount without signatories. If so, then I propose to make modifications to all the constructors Account::new/Decode/Deserialize to only allow creation of Accounts with at least one signatory

This might be a potentially API changing modification
@mversic mversic added api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Jan 18, 2024
@Arjentix Arjentix self-assigned this Feb 19, 2024
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 20, 2024
@Arjentix
[feature] hyperledger#4212: Prevent account registration without sign…
f4deac9 
…atures

Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 20, 2024
@Arjentix
[feature] hyperledger#4212: Prevent account registration without sign…
183ea07 
…atures

Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix Arjentix mentioned this issue Feb 20, 2024
Merged
5 tasks
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 21, 2024
@Arjentix
[feature] hyperledger#4212: Prevent account registration without sign…
6fd45d2 
…atures

Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 23, 2024
@Arjentix
[feature] hyperledger#4212: Prevent account registration without sign…
b28f02f 
…atures

Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 23, 2024
@Arjentix
[feature] hyperledger#4212: Prevent account registration without sign…
8d55b9e 
…atures

Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added a commit that referenced this issue Feb 26, 2024
@Arjentix
[feature] #4212: Prevent account registration without signatures
41c08b4 
Signed-off-by: Daniil Polyakov <[email protected]>
@AlexStroke AlexStroke self-assigned this Mar 1, 2024
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

@alexstroke1 alexstroke1

Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Arjentix @mversic @AlexStroke @alexstroke1