-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Overhaul RFC #3
Conversation
Signed-off-by: Dmitry Balashov <[email protected]>
I think we should also add a way to inject private parameters in a configuration. Those parameters should start with an underscore and should never be a part of our public API contract (and would most likely be only used during testing). If any user depends on this parameter it's on their own responsibility. A good example of such a parameter is |
@mversic, I thought about this topic too when faced those several parameters "for development/debugging/testing purposes". Agreed that they should not be a part of our public API. As for the format, I have some alternatives. IMO, using named nested sections for it might be more explicit: [sumeragi.debug]
force_soft_fork = true
[kura.debug]
output_new_blocks = true Another way might be to have an entirely separate [debug]
sumeragi.force_soft_fork = true
kura.output_new_blocks = true Not sure what keyword to use for it: |
- Include dev-only fields - Include migration tool mention - Include human-readable types proposal - Remove "dual view" proposal as extra Signed-off-by: Dmitry Balashov <[email protected]>
New changes:
|
Signed-off-by: Dmitry Balashov <[email protected]>
Rendered
Original PR:
Checklist