Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility of checking transaction status by hash #69

Merged
merged 1 commit into from
May 2, 2021
Merged

Add possibility of checking transaction status by hash #69

merged 1 commit into from
May 2, 2021

Conversation

baziorek
Copy link
Member

I noticed that sometimes statuses are not receiving in timeout, if it happen it is really hard to find out what was reason of the transaction if it is not committed - is it still pending, or it was rejected.
So I've decided that it would be really useful if iroha-python has functionality as iroha-cli to check status of transaction.
The functionality is really important for me, because I'm integrating external payment system to transfer tokens to iroha from online-bank-transfer, so I must know if transaction in iroha was COMMITTED, REJECTED, or PENDING to provide proper reaction.

@baziorek
Copy link
Member Author

@MBoldyrev: Could You please take a look?

@kamilsa
Copy link

kamilsa commented Apr 29, 2021

@kuvaldini will check functionality and review the code

@kuvaldini
Copy link

@kamilsa I tested. Works fine.

@stepanLav
Copy link

stepanLav commented Apr 29, 2021

I tested too, looks correct

@baziorek
Copy link
Member Author

Thanks for reviewing. I don't have permissions to merge the merge request, so if it is reviewed and looks OK somebody with the permissions needs to merge:).

@MBoldyrev MBoldyrev merged commit 4d10eb0 into hyperledger:master May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants