Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add env vars for SERVICE_ENDPOINTS #335

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

elribonazo
Copy link
Contributor

Description:

Improving the docker-compose file by adding SERVICE_ENDPOINTS env var and setting it by default to what it was today.
This is gonna be used by the QSG to make the Mediator rechable from inside docker (which cannot reach localhost)

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

github-actions bot commented Aug 13, 2024

Integration Test Results

 5 files  ±0   5 suites  ±0   11s ⏱️ ±0s
17 tests ±0  17 ✅ ±0  0 💤 ±0  0 ❌ ±0 
20 runs  ±0  20 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ba9c4d6. ± Comparison against base commit a43fe38.

♻️ This comment has been updated with latest results.

@elribonazo elribonazo force-pushed the fix/add-SERVICE_ENDPOINTS-env-var branch from 92fd0e6 to 53fe005 Compare August 13, 2024 10:43
@FabioPinheiro
Copy link
Contributor

DID you tested this?

@elribonazo elribonazo force-pushed the fix/add-SERVICE_ENDPOINTS-env-var branch from fc2bd84 to ba9c4d6 Compare August 13, 2024 11:00
Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elribonazo elribonazo merged commit f2b078a into main Aug 13, 2024
5 checks passed
@elribonazo elribonazo deleted the fix/add-SERVICE_ENDPOINTS-env-var branch August 13, 2024 11:11
hyperledger-bot added a commit that referenced this pull request Oct 2, 2024
# [1.0.0](v0.15.0...v1.0.0) (2024-10-02)

### Bug Fixes

* add env vars for SERVICE_ENDPOINTS ([#335](#335)) ([f2b078a](f2b078a))
* rename repo link to hyperledger/identus-mediator ([#331](#331)) ([69f0124](69f0124))
* wrong mediator repository in docker compose ([#334](#334)) ([a43fe38](a43fe38))

### chore

* Mediator Version 1.0.0 ([#354](#354)) ([af65517](af65517))

### BREAKING CHANGES

* Mediator Version 1.0.0

Signed-off-by: FabioPinheiro <[email protected]>

Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants