Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:replace docker-compose with docker compose #220

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix:replace docker-compose with docker compose #220

merged 2 commits into from
Feb 2, 2024

Conversation

HenrySaya
Copy link
Contributor

No description provided.

FabioPinheiro
FabioPinheiro reviewed Feb 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@FabioPinheiro
Remove extra white space
7d45efb 
Signed-off-by: Fabio Pinheiro <[email protected]>
FabioPinheiro
FabioPinheiro approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for the pull request

@FabioPinheiro
Copy link
Contributor

It's safe to merge without running the integration tests. (this didn't touch code)

@shaileshp0110 I see other two things we need to check.
1- Why do we need a username/password to download the docker image with integration tests.
2- The GitHub action that runs the integration tests can run on any pull request even when coming from another repository. We need to make sure that we don't use any secrets if not it doesn't go into work. https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@mineme0110 mineme0110 merged commit b8aee23 into hyperledger:main Feb 2, 2024
1 of 2 checks passed
@FabioPinheiro FabioPinheiro mentioned this pull request Feb 2, 2024
Closed
mineme0110 pushed a commit that referenced this pull request Apr 30, 2024
@HenrySaya @mineme0110
fix:replace docker-compose with docker compose (#220)
3f70428
mineme0110 pushed a commit that referenced this pull request Apr 30, 2024
@HenrySaya
fix:replace docker-compose with docker compose (#220)
f0ed0eb 
Signed-off-by: Henry <>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@HenrySaya
fix:replace docker-compose with docker compose (#220)
660a2e4 
Signed-off-by: Henry <>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@HenrySaya
fix:replace docker-compose with docker compose (#220)
de75e7e 
Signed-off-by: Henry  Saya <[email protected]>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@HenrySaya @mineme0110
fix:replace docker-compose with docker compose (#220)
ae8f075 
Signed-off-by: Henry  Saya <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@HenrySaya @mineme0110
fix:replace docker-compose with docker compose (#220)
ff276c7 
Signed-off-by: Henry  Saya <[email protected]>

Signed-off-by: Shailesh Patil <[email protected]>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@HenrySaya @mineme0110
fix:replace docker-compose with docker compose (#220)
a9e42f6 
Signed-off-by: Henry  Saya <[email protected]>

Signed-off-by: Shailesh Patil <[email protected]>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
@HenrySaya @mineme0110
fix:replace docker-compose with docker compose (#220)
cee761f 
Signed-off-by: Henry  Saya <[email protected]>

Signed-off-by: Shailesh Patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petevielhaber petevielhaber petevielhaber approved these changes

@FabioPinheiro FabioPinheiro FabioPinheiro approved these changes

@mineme0110 mineme0110 Awaiting requested review from mineme0110

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HenrySaya @FabioPinheiro @petevielhaber @mineme0110