feat(pluto): add keychain capabilities #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncalo-frade-iohk
requested review from
elribonazo,
hamada147,
curtis-h and
cristianIOHK
hamada147
approved these changes
Sep 3, 2023
| @@ -81,6 +81,7 @@ final class PackEncryptedOperation: OnPackEncryptedResult { | |||
| } | |||
|
|
|||
| func success(result: String, metadata: PackEncryptedMetadata) { | |||
| print(result) | |||
There was a problem hiding this comment.
To be removed, missed during debug
There was a problem hiding this comment.
Yup nice catch ;)
| @@ -1,7 +1,7 @@ | |||
| import Domain | |||
| import Foundation | |||
|
|
|||
| extension AttachmentDescriptor: Codable { | |||
There was a problem hiding this comment.
Why did you remove the Codable but kept the CodingKeys
There was a problem hiding this comment.
Actually all file needs to be removed this is now duplicated on Domain ;) Removed
Now keys will save on the keychain if they conform to the KeychainStorableKey, this is true by default on the keys created by Apollo Pluto will take care of the saving and fetching the keys from the blockchain. This allows for secrets to be shared between apps and to be synchronised to iCloud if required, although all this is by opt in
goncalo-frade-iohk
force-pushed
the
feature/ATL-5107
branch
from
b189ed2 to
2f866b0
Compare
Thx mate :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now keys will save on the keychain if they conform to the KeychainStorableKey, this is true by default on the keys created by Apollo Pluto will take care of the saving and fetching the keys from the blockchain.
This allows for secrets to be shared between apps and to be synchronised to iCloud if required, although all this is by opt in