Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): implement messages stream #61

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

goncalo-frade-iohk
Copy link
Contributor

This commit also adds Pickup Status implementation since its needed for the pickup messages protocol

Fixes ATL-2707

@goncalo-frade-iohk goncalo-frade-iohk requested review from a team December 11, 2022 14:17
@github-actions
Copy link

github-actions bot commented Dec 11, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY checkov yes no 9.32s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 1.18s
✅ REPOSITORY syft yes no 0.69s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@@ -8,7 +8,7 @@ public struct OutOfBandInvitation: Decodable {
public let goal: String?
public let accept: [String]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already commented that in another PR. Make accept also optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! ;)

Base automatically changed from feature/ATL-2704 to main December 15, 2022 13:58
This commit also adds Pickup Status implementation since its needed
for the pickup messages protocol

Fixes ATL-2707
@goncalo-frade-iohk goncalo-frade-iohk merged commit c62bb2a into main Dec 15, 2022
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-2707 branch December 15, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants