Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pluto): hide pluto codable implementation for messages and did #55

Merged
merged 1 commit into from
Dec 7, 2022
Merged

feat(pluto): hide pluto codable implementation for messages and did #55

merged 1 commit into from
Dec 7, 2022

Conversation

goncalo-frade-iohk
Copy link
Contributor

No description provided.

@goncalo-frade-iohk goncalo-frade-iohk requested review from a team December 6, 2022 11:58
@github-actions
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY checkov yes no 9.93s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 3.12s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 1.06s
✅ REPOSITORY syft yes no 0.56s
✅ YAML prettier 1 0 0.44s
✅ YAML yamllint 1 0 0.22s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/FixMessagesCodableAccess branch from 0959f65 to 85180b4 Compare December 6, 2022 12:29
cristianIOHK
cristianIOHK approved these changes Dec 6, 2022
View reviewed changes
Copy link

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rodolfomiranda
rodolfomiranda approved these changes Dec 7, 2022
View reviewed changes
Copy link

@rodolfomiranda rodolfomiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feature/ATL-2648 to main December 7, 2022 18:57
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/FixMessagesCodableAccess branch from 85180b4 to d470d4a Compare December 7, 2022 18:59
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/FixMessagesCodableAccess branch from d470d4a to 713fc04 Compare December 7, 2022 19:01
@goncalo-frade-iohk goncalo-frade-iohk merged commit 849a61f into main Dec 7, 2022
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/FixMessagesCodableAccess branch December 7, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@rodolfomiranda rodolfomiranda rodolfomiranda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @rodolfomiranda @cristianIOHK