feat(pollux): add verifiable credentials #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page MegaLinter is graciously provided by |
elribonazo
approved these changes
Dec 6, 2022
FabioPinheiro
approved these changes
Dec 6, 2022
Domain/Sources/Models/DID.swift
Outdated
| /// - Parameter string: DID String | ||
| public init(string: String) throws { | ||
| var aux = string.components(separatedBy: ":") | ||
| guard aux.count > 3 else { throw CastorError.invalidDIDString } |
There was a problem hiding this comment.
You should have three-part but I'm not sure you can split by ':'. (the first must be 'did' and the second part is the method. But the three-part is evening even without a '#')
However, I think I do the same thing in some places
There was a problem hiding this comment.
Yeah this is not the preferred way. I added a comment saying that.
There can be methodId with : in the middle. So this code can actually produce more than 3.
But yeah after your comment I noticed it needs to be >= 3
Fixes ATL-2606
goncalo-frade-iohk
force-pushed
the
feature/ATL-2606
branch
from
4bb90db to
515f3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ATL-2606