Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apollo): add 1.4 prism crypto #21

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

goncalo-frade-iohk
Copy link
Contributor

This will also add the swift package as a local. This method is not ideal and will be changing in the future.

WARNING: The next few PRs will break CI and builds. This is expected.

@github-actions
Copy link

github-actions bot commented Nov 16, 2022

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ C cpplint 2 41978 28.58s
❌ CPP cpplint 2 41978 29.76s
✅ REPOSITORY checkov yes no 8.19s
❌ REPOSITORY devskim yes 90 24.75s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.47s
✅ REPOSITORY git_diff yes no 0.35s
✅ REPOSITORY secretlint yes no 4.54s
✅ REPOSITORY syft yes no 0.55s
✅ REPOSITORY trivy yes no 2.74s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our SDK progress call last week, you are using 1.4 crypto until Apollo is ready.

@goncalo-frade-iohk
Copy link
Contributor Author

Based on our SDK progress call last week, you are using 1.4 crypto until Apollo is ready.

@2byrds yup this is the case. But I would like not to commit completely the framework in the repo. But this is not so easy right now

Base automatically changed from feature/ATL-1995 to main November 22, 2022 09:49
This will also add the swift package as a local. This method is not ideal and will be changing in the future.
@goncalo-frade-iohk goncalo-frade-iohk merged commit 8802747 into main Nov 24, 2022
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-2177 branch November 24, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants