Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeAgent): KID will be present on any signed JWTs #170

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Sep 23, 2024

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
Copy link
Contributor

carefull with DCO please but looks good!

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/OIDC-Preparation-Refactoring branch 2 times, most recently from 80571a6 to 65ff99d Compare September 25, 2024 14:40
Base automatically changed from feature/OIDC-Preparation-Refactoring to main September 26, 2024 09:48
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/atl-7641 branch 2 times, most recently from c8a1ade to c7ebf1e Compare October 3, 2024 12:20
@coveralls
Copy link

coveralls commented Oct 3, 2024

Pull Request Test Coverage Report for Build 11460960774

Details

  • 53 of 77 (68.83%) changed or added relevant lines in 14 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 42.738%

Changes Missing Coverage Covered Lines Changed/Added Lines %
EdgeAgentSDK/Apollo/Sources/Model/Ed25519Key.swift 0 1 0.0%
EdgeAgentSDK/Apollo/Sources/Model/X25519Key.swift 0 1 0.0%
EdgeAgentSDK/Castor/Sources/Resolvers/PeerDIDResolver.swift 6 7 85.71%
EdgeAgentSDK/EdgeAgent/Sources/DIDCommAgent/DIDCommAgent+Invitations.swift 4 5 80.0%
EdgeAgentSDK/Mercury/Sources/DIDCommWrappers/DIDCommDIDResolverWrapper.swift 0 1 0.0%
EdgeAgentSDK/Apollo/Sources/Model/Secp256k1Key.swift 2 4 50.0%
EdgeAgentSDK/Apollo/Sources/Operations/CreateEd25519KeyPairOperation.swift 2 4 50.0%
EdgeAgentSDK/Pollux/Sources/Operation/JWT/CreateJWTCredentialRequest.swift 0 7 0.0%
EdgeAgentSDK/Apollo/Sources/ApolloImpl+Public.swift 16 24 66.67%
Files with Coverage Reduction New Missed Lines %
EdgeAgentSDK/EdgeAgent/Sources/DIDCommAgent/DIDCommAgent+Invitations.swift 2 56.25%
Totals Coverage Status
Change from base Build 11052319165: 0.1%
Covered Lines: 5488
Relevant Lines: 12841

💛 - Coveralls

@goncalo-frade-iohk goncalo-frade-iohk merged commit b8a6855 into main Oct 22, 2024
4 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/atl-7641 branch October 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants