Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(castor): add DIDParser #17

Merged
merged 4 commits into from
Nov 21, 2022
Merged

feat(castor): add DIDParser #17

merged 4 commits into from
Nov 21, 2022

Conversation

goncalo-frade-iohk
Copy link
Contributor

Fixes ATL-1993

@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY checkov yes no 12.64s
✅ REPOSITORY devskim yes no 1.0s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 0.23s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 1.23s
✅ REPOSITORY syft yes no 0.55s
✅ REPOSITORY trivy yes no 3.23s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@goncalo-frade-iohk
feat(agent): fix open api download location
e09a9b2
@goncalo-frade-iohk
feat(castor): add antlr DID grammar
11d3f15 
This grammar will help parsing DIDs based on W3 Standardisation.
It follows the following ABNF rules: https://www.w3.org/TR/did-core/#did-syntax

It uses Antlr (https://www.antlr.org) a well known for language recognition that can
generate parsers for different languages.

Fixes ATL-1992
@goncalo-frade-iohk goncalo-frade-iohk requested a review from a team November 16, 2022 13:45
milosh86
milosh86 approved these changes Nov 18, 2022
View reviewed changes
Copy link

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feature/ATL-1992 to feature/ATL-2011 November 21, 2022 11:54
Base automatically changed from feature/ATL-2011 to main November 21, 2022 12:04
@goncalo-frade-iohk goncalo-frade-iohk merged commit 68b78e9 into main Nov 21, 2022
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-1993 branch November 21, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosh86 milosh86 milosh86 approved these changes

@elribonazo elribonazo elribonazo approved these changes

@hamada147 hamada147 Awaiting requested review from hamada147

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @elribonazo @milosh86