Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(domain): add DID standard model #14

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

goncalo-frade-iohk
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 12, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY checkov yes no 6.81s
✅ REPOSITORY devskim yes no 0.69s
✅ REPOSITORY dustilock yes no 0.0s
✅ REPOSITORY gitleaks yes no 0.15s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 2.0s
✅ REPOSITORY syft yes no 0.84s
✅ REPOSITORY trivy yes no 2.21s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-1789 branch 3 times, most recently from 9329431 to 5d9b327 Compare September 12, 2022 23:06
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// Represents a DID with ``DIDMethod`` and ``DIDMethodId``
/// As specified in [w3 standards](https://www.w3.org/TR/did-core/#dfn-did-schemes)
public struct DID {
public let schema: String

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean scheme? The rest LGTM

Copy link
Contributor Author

@goncalo-frade-iohk goncalo-frade-iohk Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well least from a English perspective it is a Schema. But in W3 documents is written Scheme xD

As nouns the difference between scheme and schema is that scheme is a systematic plan of future action while schema is an outline or image universally applicable to a general conception, under which it is likely to be presented to the mind. 

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-1783 branch 2 times, most recently from d8d5413 to 331c65e Compare September 13, 2022 11:07
Base automatically changed from feature/ATL-1783 to main September 13, 2022 14:16
@goncalo-frade-iohk goncalo-frade-iohk merged commit 95654a4 into main Sep 14, 2022
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-1789 branch September 14, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants