WIP Chain APIs for pkg/configtx orderer, application, consortium, and channel operations #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlahti
commented
Apr 24, 2020
| @@ -262,7 +262,7 @@ func newApplicationGroup(application Application) (*cb.ConfigGroup, error) { | |||
| applicationGroup := newConfigGroup() | |||
| applicationGroup.ModPolicy = AdminsPolicyKey | |||
|
|
|||
| if err = addPolicies(applicationGroup, application.Policies, AdminsPolicyKey); err != nil { | |||
| if err = setPolicies(applicationGroup, application.Policies, AdminsPolicyKey); err != nil { | |||
There was a problem hiding this comment.
Cleanup unrelated to the overall goal of this PR but it stood out as I was looking at the new API calls and this underlying private function's naming was inconsistent.
wlahti
force-pushed
the
fab-17744
branch
3 times, most recently
from
fe9f3ff to
49c1049
Compare
wlahti
changed the title
wlahti
force-pushed
the
fab-17744
branch
4 times, most recently
from
9940087 to
f649f6e
Compare
wlahti
changed the title
FAB-17744 Signed-off-by: Will Lahti <[email protected]>
FAB-17744 Signed-off-by: Will Lahti <[email protected]>
FAB-17744 Signed-off-by: Will Lahti <[email protected]>
wlahti
changed the title
|
/ci-run |
FAB-17744 Signed-off-by: Will Lahti <[email protected]>
|
closing, moved to hyperledger/fabric-config#11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
First commit:
Second commit:
Third commit:
Fourth commit:
Related issues
FAB-17744