Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing argument in help information for command "peer lifecycle chaincode install" #4976

Closed
jmmunoz-kolokium opened this issue Sep 10, 2024 · 4 comments

Comments

@jmmunoz-kolokium
Copy link
Contributor

https://github.com/hyperledger/fabric/blame/0afafb845746653c19c9e815060998c418cad436/docs/source/commands/peerlifecycle.md#L119

In my opinion, the help information for this command is missing the package file parameter which should come after the word "install".

@jmmunoz-kolokium jmmunoz-kolokium changed the title Missing argument in command "peer lifecycle chaincode install" Missing argument in help information for command "peer lifecycle chaincode install" Sep 10, 2024
@satota2
Copy link
Contributor

satota2 commented Sep 12, 2024

@jmmunoz-kolokium
Thank you for the report. I agree with your observation that the parameter is missing and should be added. The command should be updated as follows:

peer lifecycle chaincode install [packageFiles] [flags]

Would you be interested in creating a PR to fix this, or was your intention to simply report the bug?
If you'd like to handle the PR, your contribution would be very welcome. If it's the latter, I can go ahead and create a PR for this.

@jmmunoz-kolokium
Copy link
Contributor Author

@satota2 , Thank you for your reply.

Since this is my first contribution, I would be interested on handling this PR so I can see the full process.

I will create the PR as soon as possible, after reading the contribution guide.

Regards

@satota2
Copy link
Contributor

satota2 commented Sep 12, 2024

@jmmunoz-kolokium
Thank you for your contribution! I look forward to seeing your PR.
If you have any questions along the way, feel free to ask.

@jmmunoz-kolokium
Copy link
Contributor Author

I have just created the pull request (my first one!). I hope it sticks to the project guidelines.

#4989

jmmunoz-kolokium added a commit to jmmunoz-kolokium/kolokium-update_peer_help that referenced this issue Oct 7, 2024
Signed-off-by: Juanma Muñoz <[email protected]>

Add packageFiles argument when presenting "peer lifecycle chaincode
install" help information

Resolves hyperledger#4976
jmmunoz-kolokium added a commit to jmmunoz-kolokium/kolokium-update_peer_help that referenced this issue Oct 7, 2024
Signed-off-by: Juanma Muñoz <[email protected]>

Add packageFiles argument when presenting "peer lifecycle chaincode
install" help information

Resolves hyperledger#4976
jmmunoz-kolokium added a commit to jmmunoz-kolokium/kolokium-update_peer_help that referenced this issue Oct 7, 2024
Signed-off-by: Juanma Muñoz <[email protected]>

Add packageFiles argument when presenting "peer lifecycle chaincode
install" help information

Resolves hyperledger#4976
@satota2 satota2 closed this as completed in d9ca702 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants