-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding examples of CCAAS and support into the test-network-k8s #527
Adding examples of CCAAS and support into the test-network-k8s #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had success with this approach and the latest default builder PR. A couple of tweaks are still necessary:
-
metadata.json should reference
ccaas
notexternal
type -
org2/peer1 is still loading an init container with the fabric-ccaas-builder image from ghca.io, it should be scrubbed.
-
org2/peer2 should also propagate the CHAINCODE_AS_A_SERVICE_BUILDER_CONFIG in env.
39996f3
to
c82338c
Compare
c82338c
to
dc085f0
Compare
This looks better but still needs the 'external' -> 'ccaas' type updated in the metadata.json files. Also just a reminder (to @jkneubuh) that this PR should not land until after the gateway / 2.4.x images are available on the public repositories. |
built-in as-a-service chaincode builder from the Peer Container Signed-off-by: Matthew B White <[email protected]>
d4bf866
to
059a1d0
Compare
@jkneubuh I've updated this, and checked it's working with the very latest docker images from Artifactory. Updated 15December - confirmed that this is still working as expected. |
…onfig Signed-off-by: Josh Kneubuhl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matthew I really like this PR. Working with the new, default CCAAS builder is a huge relief and really makes it easy to work with smart contracts on K8s.
I took the liberty of pushing a few extra changes into this branch / fork / PR. Feel free to squash the commits if desired:
-
Bumped the ./network
TEST_NETWORK_FABRIC_VERSION
to 2.4.1. (Note: this PR still needs to linger for a couple more days until the patch images have been uploaded to the Docker Hub.) -
org 2's peer1 config yaml was still referencing the labs ccaas-builder image from ghcr.io in an init container. NONE of the peers reference the hyperledendary init container in the current PR.
-
There were a couple of md docs referencing the hyperledgendary init container. Also scrubbed.
Overall, it looks great, works great, and ... just works. I really, really like how this opens the door for running chaincode endpoints in a local IDE/debugger, and is seamlessly linked up with the new builder. The use of the templating in the connection JSON is a brilliant technique to match the cc hash, independent of the service URL. Nice one.
Really great. I "triple-approve" : 👍 👍 👍
@jkneubuh thanks for the updates!! must remember not to merge this just yet... |
Using the variant of the peer's docker container from hyperledger/fabric#2990 this PR adapts the K8S deployment to use this inbuilt chaincode builder.
Signed-off-by: Matthew B White [email protected]