Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secure version of JUnit v4 for compilation. #332

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Use secure version of JUnit v4 for compilation. #332

merged 1 commit into from
Mar 7, 2024

Conversation

benjsmi
Copy link
Contributor

@benjsmi benjsmi commented Mar 6, 2024

https://nvd.nist.gov/vuln/detail/CVE-2020-15250 indicates that junit:junit:4.12 is insecure. But it has been patched and there's an easy fix to just move to v4.13.1.

@benjsmi benjsmi requested a review from a team as a code owner March 6, 2024 19:25
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would update to JUnit 5 across the board but that is a little more work to do properly. If sticking with JUnit 4, any reason not to pick v4.13.2 instead of v4.13.1?

Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@benjsmi
Copy link
Contributor Author

benjsmi commented Mar 7, 2024

@bestbeforetoday
Nope; no reason. I overwrote my commit with a new one that moves to v4.13.2

@bestbeforetoday bestbeforetoday merged commit 0b08b97 into hyperledger:main Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants