try to fix #106 #108
Merged
try to fix #106 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamYuan1990
force-pushed
the
tryApprovePolicy
branch
2 times, most recently
from
de5fd6b to
10ccfcd
Compare
SamYuan1990
force-pushed
the
tryApprovePolicy
branch
from
10ccfcd to
61f2356
Compare
|
@bestbeforetoday , if there no further comments for this PR, I would like to merge it early next week. |
There was a problem hiding this comment.
Suggestions for simplifying the API and usage in comments to consider.
I would also suggest only exporting a minimal set of functions. Several of the functions in signaturepolicy.go are capitalized and so are public. I'm not sure any of them need to be. Perhaps keep the public API to a single function until there is a clear need for more.
Signed-off-by: Sam Yuan <[email protected]>
SamYuan1990
force-pushed
the
tryApprovePolicy
branch
from
61f2356 to
5c76227
Compare
bestbeforetoday
requested changes
Mar 29, 2023
Signed-off-by: Sam Yuan <[email protected]>
Signed-off-by: Sam Yuan <[email protected]>
Signed-off-by: Sam Yuan <[email protected]>
bestbeforetoday
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose we need to provide function to support approve sign for chaincode level and channel level.
this PR is just a draft as POC.