Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS/mTLS options and configure the GraphQL HTTP service #7910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pullurib
Copy link
Contributor

PR Description

Summary

The changes include the addition of command-line options to enable and configure TLS and mTLS for the GraphQL HTTP service.

Changes

  1. New Command-Line Options:

    • --graphql-tls-enabled: Enable TLS for the GraphQL HTTP service.
    • --graphql-tls-keystore-file: Path to the TLS keystore file.
    • --graphql-tls-keystore-password-file: Path to the file containing the password for the TLS keystore.
    • --graphql-mtls-enabled: Enable mTLS for the GraphQL HTTP service.
    • --graphql-tls-truststore-file: Path to the TLS truststore file.
    • --graphql-tls-truststore-password-file: Path to the file containing the password for the TLS truststore.
  2. Validation of Option Dependencies:

    • Added checks to ensure that the necessary TLS options are provided when TLS or mTLS is enabled.

Testing

  • Added unit tests to verify the new TLS options and their dependencies.
  • Ensured existing tests for GraphQL HTTP service are passing.

Documentation

  • Updated the CHANGELOG.md to reflect the addition of new TLS options.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Bhanu Pulluri added 2 commits November 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant