Fix BlockchainQueries::gasPrice when chain head block body still not fully persisted #7482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fully persisted Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
fix-blockchainQueries-getPrice
branch
from
81bf4fd
to
444cd7d
Compare
fab-10
changed the title
Signed-off-by: Fabio Di Fabio <[email protected]>
cloudspores
pushed a commit
to cloudspores/besu
that referenced
this pull request
Aug 23, 2024
…fully persisted (hyperledger#7482) * Fix BlockchainQueries::gasPrice when chain head block body still not fully persisted Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…fully persisted (hyperledger#7482) * Fix BlockchainQueries::gasPrice when chain head block body still not fully persisted Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
As well explained by @matthew1001 here, since in PR #7102, the current chain head is correctly included in the computation of the gasPrice, it could happen that the chain head block body is still not persisted, so in order to always retrieve it successfully we first try optimistically, then if not found, the new
getBlockBodySafethat is synchronized and so will wait until the pending persist operation is done.Fixed Issue(s)
fixes #7287
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests