Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: always use miningParametersSupplier #7187

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Jun 6, 2024

PR description

#7102 introduced a regression that broke the ethereum_min_gas_price and ethereum_min_priority_fee metrics, since miningParameters where created twice, instead of always use the miningParametersSupplier

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 enabled auto-merge (squash) June 6, 2024 15:14
@fab-10 fab-10 merged commit bf67c6a into hyperledger:main Jun 6, 2024
40 checks passed
gtebrean pushed a commit to gtebrean/besu that referenced this pull request Jun 26, 2024
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: George Tebrean <[email protected]>
@fab-10 fab-10 deleted the fix-always-use-mining-parameter-supplier branch July 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants