Fix: Fallback to getName when canonicalName is null in BlockHeaderValidator DEBUG log

[manojpramesh]

PR description

When a validation rule fails in BlockHeaderValidator, debug message falls back to using just name when canonical name is not available.

Fixed Issue(s)

Fixes #6177

[github-actions]

• I thought about documentation and added the doc-change-required label to this PR if updates are required.
• I thought about the changelog and included a changelog update if required.
• If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

[manojpramesh]

@macfarla Thank you for the approval. Anything pending from my side to get this merged?

Also, what is the recommended approach to pull latest changes from main? Merge commit or rebase?

[macfarla]

@manojpramesh just catching up properly on things after the break - have you tested out that this works as you expect? This suggests that for inner classes getName might be the option that works https://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav

and once you have tested it out - can you provide before/after log messages?

[macfarla]

@macfarla Thank you for the approval. Anything pending from my side to get this merged?

Also, what is the recommended approach to pull latest changes from main? Merge commit or rebase?

personal preference on merge or rebase. I did hit merge on your PR though so you'll need to pull before you push

This suggests that for inner classes getName might be the option that works https://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav

[manojpramesh]

Agree with using getName to include the packageName while logging.

Here's the log when canonicalName is null after the fix. Since it's a lambda function, you can see it returns the counter generated during runtime - which I guess should be okay for a DEBUG log.

2024-01-08 23:02:21.016+08:00 | EthScheduler-Workers-0 | INFO  | TimestampMoreRecentThanParent | Invalid block header: timestamp 1704726141 is only 10 seconds newer than parent timestamp 1704726131. Minimum 15 seconds
2024-01-08 23:02:28.106+08:00 | EthScheduler-Workers-0 | DEBUG | BlockHeaderValidator | org.hyperledger.besu.ethereum.mainnet.BlockHeaderValidator$Builder$$Lambda$486/0x00000008004a5020 rule failed

[macfarla]

Thanks for the contribution @manojpramesh