Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate bft and clique ATs to junit 5 #6249

Closed
wants to merge 14 commits into from

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Dec 6, 2023

fixes #6261

Copy link

github-actions bot commented Dec 6, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
Copy link
Contributor Author

macfarla commented Dec 7, 2023

I can successfully run the acceptanceTestCliqueBft task locally but in CI it seems to be killed

Build request sent: Build{id=6cd101fe-8b8c-4893-bbdd-c227ed345cea, currentDir=/home/circleci/project}
Attempting to read last messages from the daemon log...
Daemon pid: 766
  log file: /home/circleci/.gradle/daemon/7.6/daemon-766.out.log
----- Last  20 lines from daemon log file - daemon-766.out.log -----
2023-12-07T04:41:45.793+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2023-12-07T04:41:45.797+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] resetting idle timer
2023-12-07T04:41:45.797+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] daemon is running. Sleeping until state changes.
2023-12-07T04:41:45.797+0000 [INFO] [org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy] Daemon is about to start building Build{id=6cd101fe-8b8c-4893-bbdd-c227ed345cea, currentDir=/home/circleci/project}. Dispatching build started information...
2023-12-07T04:41:45.798+0000 [DEBUG] [org.gradle.launcher.daemon.server.SynchronizedDispatchConnection] thread 31: dispatching org.gradle.launcher.daemon.protocol.BuildStarted@68cff0e9
2023-12-07T04:41:45.799+0000 [DEBUG] [org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment] Configuring env variables: [PATH, MILL_VERSION, NO_PROXY, GRADLE_OPTS, CIRCLE_WORKFLOW_WORKSPACE_ID, SBT_VERSION, CIRCLE_PR_USERNAME, CIRCLE_PULL_REQUEST, CIRCLE_PROJECT_REPONAME, CIRCLE_WORKING_DIRECTORY, CIRCLE_INTERNAL_TASK_DATA, PWD, LANGUAGE, BASH_ENV, GRADLE_VERSION, PAGER, CIRCLE_BUILD_NUM, CI_PULL_REQUEST, MAVEN_VERSION, COMPOSE_VER, CIRCLE_SHA1, CIRCLE_NODE_INDEX, CIRCLE_NODE_TOTAL, DEBIAN_FRONTEND, LC_ALL, CIRCLE_SHELL_ENV, SHLVL, CIRCLE_PLUGIN_TEST, COMPOSE_SWITCH_VERSION, DOCKER_VERSION, CIRCLE_PR_REPONAME, JAVA_HOME, CIRCLE_PROJECT_USERNAME, TERM, LANG, CIRCLE_INTERNAL_SCRATCH, CIRCLE_BUILD_URL, CIRCLE_BRANCH, CIRCLE_PULL_REQUESTS, JAVA_VERSION, _, CIRCLECI, CIRCLE_USERNAME, CIRCLE_PR_NUMBER, CIRCLE_REPOSITORY_URL, CI, CIRCLE_JOB, CIRCLE_WORKFLOW_ID, SSH_AUTH_SOCK, CIRCLE_INTERNAL_CONFIG, HOSTNAME, CIRCLE_WORKFLOW_JOB_ID, HOME]
2023-12-07T04:41:45.801+0000 [DEBUG] [org.gradle.launcher.daemon.server.SynchronizedDispatchConnection] thread 29: received class org.gradle.launcher.daemon.protocol.CloseInput
2023-12-07T04:41:45.801+0000 [DEBUG] [org.gradle.launcher.daemon.server.DefaultDaemonConnection] thread 29: Received IO message from client: org.gradle.launcher.daemon.protocol.CloseInput@43c9f6d1
2023-12-07T04:41:45.803+0000 [DEBUG] [org.gradle.launcher.daemon.server.exec.LogToClient] About to start relaying all logs to the client via the connection.
2023-12-07T04:41:45.803+0000 [INFO] [org.gradle.launcher.daemon.server.exec.LogToClient] The client will now receive all logging from the daemon (pid: 766). The daemon log file: /home/circleci/.gradle/daemon/7.6/daemon-766.out.log
2023-12-07T04:41:45.805+0000 [INFO] [org.gradle.launcher.daemon.server.exec.ForwardClientInput] Closing daemon's stdin at end of input.
2023-12-07T04:41:45.806+0000 [INFO] [org.gradle.launcher.daemon.server.exec.ForwardClientInput] The daemon will no longer process any standard input.
2023-12-07T04:41:45.806+0000 [DEBUG] [org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon] Requesting daemon stop after processing Build{id=6cd101fe-8b8c-4893-bbdd-c227ed345cea, currentDir=/home/circleci/project}
2023-12-07T04:41:45.806+0000 [LIFECYCLE] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] Daemon will be stopped at the end of the build 
2023-12-07T04:41:45.806+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] Stop as soon as idle requested. The daemon is busy: true
2023-12-07T04:41:45.806+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] daemon stop has been requested. Sleeping until state changes.
2023-12-07T04:41:45.809+0000 [DEBUG] [org.gradle.launcher.daemon.server.exec.ExecuteBuild] The daemon has started executing the build.
2023-12-07T04:41:45.809+0000 [DEBUG] [org.gradle.launcher.daemon.server.exec.ExecuteBuild] Executing build with daemon context: DefaultDaemonContext[uid=6c99b3cd-bb78-41ad-b69c-66fff382696a,javaHome=/usr/local/jdk-17.0.9,daemonRegistryDir=/home/circleci/.gradle/daemon,pid=766,idleTimeout=120000,priority=NORMAL,daemonOpts=--add-exports,jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED,--add-exports,jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED,--add-exports,jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED,--add-exports,jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED,--add-exports,jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED,--add-exports,jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED,--add-exports,jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED,--add-exports,jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED,--add-opens,jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED,--add-opens,jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED,--add-opens,jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED,--add-opens=java.base/java.util=ALL-UNNAMED,--add-opens=java.base/java.lang=ALL-UNNAMED,--add-opens=java.base/java.lang.invoke=ALL-UNNAMED,--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED,--add-opens=java.base/java.nio.charset=ALL-UNNAMED,--add-opens=java.base/java.net=ALL-UNNAMED,--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED,-Xmx4g,-Dfile.encoding=UTF-8,-Duser.country=US,-Duser.language=en,-Duser.variant]
Execution optimizations have been disabled for task ':acceptance-tests:tests:processTestResources' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/home/circleci/project/acceptance-tests/test-plugins/build/libs'. Reason: Task ':acceptance-tests:tests:processTestResources' uses this output of task ':acceptance-tests:test-plugins:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6/userguide/validation_problems.html#implicit_dependency for more details about this problem.
----- End of the daemon log -----


FAILURE: Build failed with an exception.

* What went wrong:
Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

@macfarla macfarla changed the title migrate bft and some other ATs to junit 5 migrate bft and clique ATs to junit 5 Dec 8, 2023
@macfarla macfarla marked this pull request as draft December 11, 2023 00:03
@macfarla macfarla closed this Dec 12, 2023
@macfarla macfarla deleted the ats-junit-5 branch October 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate clique and bft ATs to junit 5
1 participant