Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: update goerli bootnodes #3857

Merged
merged 5 commits into from
May 29, 2022
Merged

config: update goerli bootnodes #3857

merged 5 commits into from
May 29, 2022

Conversation

q9f
Copy link
Contributor

@q9f q9f commented May 18, 2022

Signed-off-by: Afr Schoe [email protected]

PR description

I had to migrate the goerli bootnodes recently.

Fixed Issue(s)

Documentation

  • not necessary

Changelog

  • not necessary

@macfarla
Copy link
Contributor

@q9f thanks for this - there are 2 unit tests failing https://app.circleci.com/pipelines/github/hyperledger/besu/15000/workflows/9770308e-3b68-4829-8d38-eadcb58e708e/jobs/86880
Additionally it would be appreciated if your signoff could be made with a functional email address - I think if you set user.email in your git config as per https://github.com/hyperledger/besu/blob/main/DCO.md

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mark-terry mark-terry merged commit 501ba64 into hyperledger:main May 29, 2022
@q9f q9f deleted the q9f/config/goerli branch May 30, 2022 10:35
@macfarla macfarla mentioned this pull request Jun 8, 2022
Closed
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@q9f @shemnon
@mark-terry @eum602
config: update goerli bootnodes (hyperledger#3857)
be2fe83 
* config: update goerli bootnodes

Signed-off-by: Afr Schoe <[email protected]>

* Test resource updates.

Signed-off-by: mark-terry <[email protected]>

Co-authored-by: Danno Ferrin <[email protected]>
Co-authored-by: mark-terry <[email protected]>
Co-authored-by: mark-terry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@q9f @macfarla @shemnon @mark-terry