Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoSuchElementException in Transaction Receipt Logic #2477

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

RatanRSur
Copy link
Contributor

@RatanRSur RatanRSur commented Jun 24, 2021

Signed-off-by: Ratan Rai Sur [email protected]

PR description

Fixed Issue(s)

fixes #2476

Changelog

@RatanRSur RatanRSur marked this pull request as ready for review June 25, 2021 00:28
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to return effective priority fee, but rather effective gas price 🤔

Wei.of(
receipt
.getTransaction()
.getEffectivePriorityFeePerGas(receipt.getBaseFee())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK - this should be effective gas, not effective priority fee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ good point

Signed-off-by: Ratan Rai Sur <[email protected]>
Signed-off-by: Ratan Rai Sur <[email protected]>
@RatanRSur RatanRSur force-pushed the dedup-effective-gas-price branch from 92290a8 to aecc10e Compare June 25, 2021 02:06
@RatanRSur RatanRSur changed the title Deduplicate Effective Gas Price Method Fix NoSuchElementException in Transaction Receipt Logic Jun 25, 2021
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean and tight 🚢

@RatanRSur RatanRSur enabled auto-merge (squash) June 25, 2021 16:13
@RatanRSur RatanRSur merged commit 375d9b6 into hyperledger:master Jun 25, 2021
RatanRSur added a commit to RatanRSur/besu that referenced this pull request Jul 8, 2021
RatanRSur added a commit to RatanRSur/besu that referenced this pull request Jul 8, 2021
RatanRSur added a commit to RatanRSur/besu that referenced this pull request Jul 8, 2021
RatanRSur added a commit to RatanRSur/besu that referenced this pull request Jul 8, 2021
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix gasPrice missing error on eth_getTransactionReceipt
2 participants