-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NoSuchElementException in Transaction Receipt Logic #2477
Fix NoSuchElementException in Transaction Receipt Logic #2477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to return effective priority fee, but rather effective gas price 🤔
Wei.of( | ||
receipt | ||
.getTransaction() | ||
.getEffectivePriorityFeePerGas(receipt.getBaseFee()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK - this should be effective gas, not effective priority fee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ good point
Signed-off-by: Ratan Rai Sur <[email protected]>
Signed-off-by: Ratan Rai Sur <[email protected]>
92290a8
to
aecc10e
Compare
Signed-off-by: Ratan Rai Sur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean and tight 🚢
…2477) Signed-off-by: Ratan Rai Sur <[email protected]>
…2477) Signed-off-by: Ratan Rai Sur <[email protected]>
…2477) Signed-off-by: Ratan Rai Sur <[email protected]>
…2477) Signed-off-by: Ratan Rai Sur <[email protected]>
…2477) Signed-off-by: Ratan Rai Sur <[email protected]>
Signed-off-by: Ratan Rai Sur [email protected]
PR description
Fixed Issue(s)
fixes #2476
Changelog