dialing down logging of invalid HELO to debug #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Florentine <[email protected]>
jflo
added a commit
to jflo/besu
that referenced
this pull request
Jun 22, 2021
Signed-off-by: Justin Florentine <[email protected]>
matkt
pushed a commit
that referenced
this pull request
Jun 22, 2021
Signed-off-by: Justin Florentine <[email protected]>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Ratan Rai Sur <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…erledger#2463) Signed-off-by: Justin Florentine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Florentine [email protected]
PR description
Previous assumption was a mistake, I didn't realize those canaries I checked were not running at DEBUG. Invalid HELOs happen often enough, without any impact, that the log level should remain at debug.
Fixed Issue(s)
fixes #2004
Changelog