Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth call post 1559 #2445

Merged
merged 11 commits into from
Jun 21, 2021

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Jun 16, 2021

PR description

Update eth_call to work correctly after the london fork

Update integration tests to be able to test JSON RPC methods after the london fork

Explained behavior :

  • Before EIP1559

    • If gasPrice is not present. 0 is used and balance account is not checked
    • If gasPrice is present. this gasPrice value is used and balance account is checked
  • After EIP1559

    • If gasPrice is not present. 0 is used and balance account is not checked (baseFee forced to 0)
    • if gasPrice is present, this value is used for the max and priority fee and the balance is checked (the current baseFee is used)
    • if max and/or priority fee are present, they are interpreted as specified and the balance is checked (the current baseFee is used)

Fixed Issue(s)

Changelog

@garyschulte
Copy link
Contributor

The eth_call changes LGTM 👍 , the diff includes some tracing changes and artifacts though - is that expected? Is this PR based on a branch that hasn't merged yet?

Signed-off-by: Karim TAAM <[email protected]>
@matkt matkt force-pushed the feature/eth_call_post-1559 branch from 118efbf to 796217c Compare June 17, 2021 09:07
@matkt
Copy link
Contributor Author

matkt commented Jun 17, 2021

The eth_call changes LGTM 👍 , the diff includes some tracing changes and artifacts though - is that expected? Is this PR based on a branch that hasn't merged yet?

I updated the code to fix the pipeline and I merged the master. The tracing is no longer present in the PR.

Also tested in a testnet locally

Signed-off-by: Karim TAAM <[email protected]>
@matkt matkt force-pushed the feature/eth_call_post-1559 branch from fb1ad3e to 33596a1 Compare June 17, 2021 11:57
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little copypasta on one test, otherwise lgtm

@matkt matkt requested a review from garyschulte June 21, 2021 13:35
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@garyschulte garyschulte enabled auto-merge (squash) June 21, 2021 15:34
@garyschulte garyschulte merged commit 87e8770 into hyperledger:master Jun 21, 2021
jflo pushed a commit to jflo/besu that referenced this pull request Jun 25, 2021
@matkt matkt deleted the feature/eth_call_post-1559 branch July 13, 2021 12:22
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants