-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eth call post 1559 #2445
Update eth call post 1559 #2445
Conversation
Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Karim TAAM <[email protected]>
The eth_call changes LGTM 👍 , the diff includes some tracing changes and artifacts though - is that expected? Is this PR based on a branch that hasn't merged yet? |
Signed-off-by: Karim TAAM <[email protected]>
118efbf
to
796217c
Compare
Signed-off-by: Karim TAAM <[email protected]>
I updated the code to fix the pipeline and I merged the master. The tracing is no longer present in the PR. Also tested in a testnet locally |
Signed-off-by: Karim TAAM <[email protected]>
fb1ad3e
to
33596a1
Compare
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/TransactionSimulator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a little copypasta on one test, otherwise lgtm
...m/core/src/test/java/org/hyperledger/besu/ethereum/transaction/TransactionSimulatorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karim TAAM <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Karim TAAM <[email protected]>
PR description
Update eth_call to work correctly after the london fork
Update integration tests to be able to test JSON RPC methods after the london fork
Explained behavior :
Before EIP1559
After EIP1559
Fixed Issue(s)
Changelog