Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for switching ProtocolSchedule rules outside of Milestones #1962

Merged
merged 8 commits into from
Mar 4, 2021

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented Mar 1, 2021

This is the first step in supporting switchable consensus mechanisms.

Specifically this allows additional protocol specs to be inserted to the protocol schedule at milestones other than that explicitly specified in the genesis config.

PR description

Fixed Issue(s)

Changelog

Trent Mohay added 2 commits March 1, 2021 14:48
@rain-on rain-on requested a review from jframe March 1, 2021 04:11
@atoulme
Copy link
Contributor

atoulme commented Mar 1, 2021

Sure, any chance #1882 can be merged in first? Looks like there’s a good chance of conflict.

Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in first. I'll rebase #1882.

@rain-on rain-on merged commit a729dbd into hyperledger:master Mar 4, 2021
@rain-on rain-on deleted the switcher branch March 4, 2021 03:40
RichardH92 pushed a commit to RichardH92/besu that referenced this pull request Mar 29, 2021
…erledger#1962)

This is the first step in supporting switchable consensus mechanisms.

Specifically this allows additional protocol specs to be inserted to the protocol schedule at milestones other than that explicitly specified in the genesis config.

Signed-off-by: Trent Mohay <[email protected]>
Signed-off-by: Richard Hart <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…erledger#1962)

This is the first step in supporting switchable consensus mechanisms.

Specifically this allows additional protocol specs to be inserted to the protocol schedule at milestones other than that explicitly specified in the genesis config.

Signed-off-by: Trent Mohay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants