Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove if not needed: getSupprtedProtocol() in BesuControllerBuilder always returns EthProtocol.NAME #7810

Closed
pinges opened this issue Oct 25, 2024 · 1 comment · Fixed by #7867 or #7922
Closed

Remove if not needed: getSupprtedProtocol() in BesuControllerBuilder always returns EthProtocol.NAME #7810

pinges opened this issue Oct 25, 2024 · 1 comment · Fixed by #7867 or #7922
Labels
snack Smaller coding task - less than a day for an experienced dev

Comments

@pinges
Copy link
Contributor

pinges commented Oct 25, 2024

Description

Looks like this protocol name is mainly used in EthPeers and EthPeer, but as it is always the same it is probably not needed.
@pinges pinges added snack Smaller coding task - less than a day for an experienced dev TeamCerberus labels Oct 25, 2024
@jflo jflo removed the TeamCerberus label Nov 5, 2024
vaidikcode added a commit to vaidikcode/besu that referenced this issue Nov 7, 2024
@vaidikcode
fix-hyperledger#7810
4e2d5f2 
Signed-off-by: vaidikcode <[email protected]>
vaidikcode added a commit to vaidikcode/besu that referenced this issue Nov 7, 2024
@vaidikcode
fix-hyperledger#7810
1471be2 
Signed-off-by: vaidikcode <[email protected]>
@vaidikcode vaidikcode mentioned this issue Nov 7, 2024
Merged
8 tasks
vaidikcode added a commit to vaidikcode/besu that referenced this issue Nov 9, 2024
@vaidikcode
Merge branch 'hyperledger:main' into fix-hyperledger#7810
a41d61d
macfarla added a commit to vaidikcode/besu that referenced this issue Nov 19, 2024
@macfarla
Merge branch 'main' into fix-hyperledger#7810
8694eff
@pinges
Copy link
Contributor Author

pinges commented Nov 26, 2024

As the supported protocol is always EthProtocol.NAME it should be possible to remove the fields in EthPeers and EthPeer.

@pinges pinges reopened this Nov 26, 2024
@pinges pinges mentioned this issue Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
snack Smaller coding task - less than a day for an experienced dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7810 vaidikcode/besu
remove protocol name pinges/besu
3 participants
@jflo @pinges and others