-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux aarch64 support for EIP196 constantine #203
Conversation
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
@garyschulte Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor nit about the the openjdk install source
constantine/build.gradle
Outdated
task macArmLibCopy(type: Copy) { | ||
from "build/darwin-aarch64/lib/libconstantine.dylib" | ||
from "build/darwin-aarch64/lib/libconstantineeip196.jnilib" | ||
into 'build/resources/main/lib/darwin-aarch64' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, testling locally I am getting
Exception in thread "main" java.lang.UnsatisfiedLinkError: no constantineeip196 in java.library.path: ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which OS are you testing this in?
I assume first you ran the ./build.sh and then the test files?
I tested in Mac and Linux x86_64, working fine for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am testing by integrating into besu on Darwin aarch64, when I build I am seeing the libs getting embedded in the jar inlib/{arch}
rather than {arch}
. The 0.9.4 build shows the same for the x86_64 libs.
Perhaps there is a classpath difference / expectation in besu-native/constantine that allows it to find the libs, but that same native classpath isn't in besu (since besu is using the jar dep instead of a filesystem build artifact). Looking into it now
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Edit: Updated Ubuntu to 22.04 for linux x86_64 pipeline, fixed the problem with GLIBC_2.34 |
Signed-off-by: Nischal Sharma <[email protected]>
@garyschulte Pipeline for Mac Arm is failing due to -
|
We can add go, it builds fine locally. It is just the packaging that is presenting a problem for me at the moment |
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
@garyschulte Pipelines are passing now. |
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
c2cb588
to
d2031f1
Compare
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
The weird requirement about darwin vs linux shared library location notwithstanding, lets MERGE this and we can sort out that minor oddity in a subsequent PR 👍 |
Fixes #198