Implement EIP-2537 using gnark-crypto #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
feature/gnark-bls12-381
branch
from
635f81f to
4a62528
Compare
garyschulte
commented
Jun 7, 2024
garyschulte
commented
Jun 7, 2024
garyschulte
commented
Jun 7, 2024
garyschulte
commented
Jun 7, 2024
garyschulte
commented
Jun 7, 2024
garyschulte
commented
Jun 7, 2024
gnark/src/main/java/org/hyperledger/besu/nativelib/gnark/LibGnarkEIP2537.java
Show resolved
Hide resolved
gnark/src/test/java/org/hyperledger/besu/nativelib/gnark/BLS12G1AddPrecompiledContractTest.java
Outdated
Show resolved
Hide resolved
garyschulte
changed the title
shemnon
approved these changes
Jun 20, 2024
Once we have a besu release with gnark-crypto, we can remove matter labs and the original altbn128 implementation 👍 |
garyschulte
force-pushed
the
feature/gnark-bls12-381
branch
from
f1023b6 to
8b0825d
Compare
garyschulte
added a commit
that referenced
this pull request
Jun 24, 2024
Signed-off-by: garyschulte <[email protected]>
garyschulte
added a commit
that referenced
this pull request
Jun 25, 2024
Signed-off-by: garyschulte <[email protected]>
ryjones
pushed a commit
that referenced
this pull request
Jun 25, 2024
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Still todo:pairing and fpToG1 fpToG2 Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…exposed Signed-off-by: garyschulte <[email protected]>
clean up blst implementation, remove timings and test loops Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…matter-labs impl in besu Signed-off-by: garyschulte <[email protected]>
…-labs add gnark eip-196 implementation and tests add tests to matter-labs eip-196 for comparison TODO: gnark eip-197 pairing currently failing Signed-off-by: garyschulte <[email protected]>
use gnark native Unmarshal for all eip196 cleanup for PR review Signed-off-by: garyschulte <[email protected]>
…mparison with gnark Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…ead of repurposing output array Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…ts, clean up 2537 implementation Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
… scalar behavior Signed-off-by: garyschulte <[email protected]>
…ark-crypto PR 510 until gnark-crypto is released Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
feature/gnark-bls12-381
branch
from
8b0825d to
7686ae2
Compare
shemnon
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement eip-2537 using gnark-crypto.
related to #165
related to #91
Motivation
The primary motivation is to get besu onto a supported library for the ECC precompiles since the matter-labs eip-1962 repo appears to be unmaintained. There is additional benefit in that gnark-crypto performs better than matter labs on every precompile benchmark.
Testing on both x86_64 and ARM64 indicate this implementation compares very favorably with the matter-labs eip-1962 implementation for all operations.