Support combination of revocable / non-revocable credentials and timestamp override #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelephant
force-pushed
the
nonrevoked-interval-checks
branch
from
71e1b71 to
7274ca0
Compare
whalelephant
changed the title
whalelephant
force-pushed
the
nonrevoked-interval-checks
branch
3 times, most recently
from
76b1625 to
599da2c
Compare
whalelephant
force-pushed
the
nonrevoked-interval-checks
branch
2 times, most recently
from
e6b9195 to
5bea53c
Compare
TimoGlastra
approved these changes
Feb 15, 2023
berendsliedrecht
approved these changes
Feb 16, 2023
src/ffi/presentation.rs
Outdated
| pub struct FfiNonrevokedIntervalOverride<'a> { | ||
| rev_reg_def_id: FfiStr<'a>, | ||
| /// Timestamp in the `PresentationRequest` | ||
| requested_from_ts: i64, |
There was a problem hiding this comment.
Might be good later on to use i32s here. I think we map them to a u64 later and it would help in the JS side where every number is an f32.
There was a problem hiding this comment.
ah good idea! fixed
src/services/helpers.rs
Outdated
| ) -> Result<(Vec<AttributeInfo>, Option<NonRevokedInterval>)> { | ||
| trace!("_get_revealed_attributes_for_credential >>> sub_proof_index: {:?}, requested_credentials: {:?}, pres_req: {:?}", | ||
| sub_proof_index, requested_proof, pres_req); | ||
| let mut nonrevoked_interval: Option<NonRevokedInterval> = None; |
There was a problem hiding this comment.
Suggested change
| let mut nonrevoked_interval: Option<NonRevokedInterval> = None; | |
| let mut non_revoked_interval: Option<NonRevokedInterval> = None; |
whalelephant
force-pushed
the
nonrevoked-interval-checks
branch
from
0b3d7a9 to
9dd8674
Compare
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
whalelephant
force-pushed
the
nonrevoked-interval-checks
branch
from
9dd8674 to
0a57d4d
Compare
|
@whalelephant is this ready to merge? Any blockers here? |
|
Do we need any updates to the FFI wrappers? If so could you point me in the right direction on what needs to be fixed? |
|
The wrapper has been implemented and this is ready to be merged. Note, it is breaking change for |
This was referenced Feb 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.