Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for test wrappers generation #2025

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Fix for test wrappers generation #2025

merged 3 commits into from
Apr 4, 2024

Conversation

NickSneo
Copy link
Contributor

@NickSneo NickSneo commented Apr 1, 2024

What does this PR do?

Adds a check to skip test wrappers generation for getDeploymentBinary

Where should the reviewer start?

review all

Why is it needed?

Fixes test wrapper generation bug

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@NickSneo NickSneo requested a review from conor10 as a code owner April 1, 2024 08:56
Signed-off-by: Nischal Sharma <[email protected]>
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.21%. Comparing base (16b133b) to head (141f2aa).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2025      +/-   ##
============================================
- Coverage     69.21%   69.21%   -0.01%     
- Complexity     3120     3121       +1     
============================================
  Files           493      493              
  Lines         13151    13153       +2     
  Branches       1694     1696       +2     
============================================
+ Hits           9103     9104       +1     
  Misses         3567     3567              
- Partials        481      482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gtebrean gtebrean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better approach would be to make that method private again and to avoid in here adding the private methods

@gtebrean gtebrean merged commit 4f38cea into master Apr 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants