Bug fix for large binary with unlink libraries codegen #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonykwok1992
force-pushed
the
bug-fix-binary-codegen
branch
from
421c84f
to
479c284
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
============================================
+ Coverage 69.20% 69.22% +0.01%
- Complexity 3122 3123 +1
============================================
Files 493 493
Lines 13145 13146 +1
Branches 1695 1695
============================================
+ Hits 9097 9100 +3
+ Misses 3557 3556 -1
+ Partials 491 490 -1 ☔ View full report in Codecov by Sentry. |
tonykwok1992
force-pushed
the
bug-fix-binary-codegen
branch
from
617016f
to
479c284
Compare
tonykwok1992
force-pushed
the
bug-fix-binary-codegen
branch
from
825c439
to
5a7b9aa
Compare
gtebrean
reviewed
Mar 20, 2024
| import com.squareup.javapoet.ParameterizedTypeName; | ||
| import com.squareup.javapoet.TypeName; | ||
| import com.squareup.javapoet.TypeSpec; | ||
| import com.squareup.javapoet.*; |
There was a problem hiding this comment.
please remove wildcard import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bug fix for large binary with unlinked libraries codegen
Where should the reviewer start?
All files
Why is it needed?
solidity bytecode with unlinked libraries can contain dollar sign (https://docs.soliditylang.org/en/latest/using-the-compiler.html) in the form of
__$hashed$__. This could potentially being interpreted as string placeholder for args replacement in Java poet, in the case that cause failure in particular is__$927c5a12e2f339676f56d42ec1c0537964$__(the $927c part). The code that contain this bug only at the case for large binary (length > 65534). The safest way to fix is just to escape all dollar using javapoet's escape rulesquare/javapoet#670