Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix versionedHashes to blobVersionedHashes #2009

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

thinkAfCod
Copy link
Contributor

What does this PR do?

The correct property name in the transaction object returned by the eth_getBlockByNumber Api should be 'blobVersionedHashes', not 'versionedHashed'.

Where should the reviewer start?

This is a short PR

Why is it needed?

The current version does not correctly parse these returned messages.

@thinkAfCod thinkAfCod requested a review from conor10 as a code owner March 4, 2024 10:01
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.20%. Comparing base (b54cfa4) to head (ac4a117).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2009   +/-   ##
=========================================
  Coverage     69.19%   69.20%           
  Complexity     3117     3117           
=========================================
  Files           493      493           
  Lines         13078    13078           
  Branches       1688     1688           
=========================================
+ Hits           9049     9050    +1     
+ Misses         3538     3537    -1     
  Partials        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkAfCod thinkAfCod changed the title fix versionedHashes to blovVersionedHashes fix versionedHashes to blobVersionedHashes Mar 4, 2024
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo NickSneo merged commit b04f116 into hyperledger-web3j:master Mar 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants