-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-4844 support #2000
EIP-4844 support #2000
Conversation
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2000 +/- ##
============================================
+ Coverage 68.65% 68.94% +0.28%
- Complexity 3040 3087 +47
============================================
Files 490 493 +3
Lines 12715 12911 +196
Branches 1653 1661 +8
============================================
+ Hits 8730 8902 +172
- Misses 3501 3522 +21
- Partials 484 487 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, also add test cases for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments/suggestions and questions.
I think test cases will confirm the question, specifically, the ability to submit a 4844 while just providing the blobs and have Web3j manage the proofs and related.
crypto/src/main/java/org/web3j/crypto/transaction/type/Transaction4844.java
Show resolved
Hide resolved
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions for review/discussion
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -21,10 +21,12 @@ ext { | |||
jnr_unixsocketVersion = '0.38.17' | |||
okhttpVersion = '4.9.0' | |||
rxjavaVersion = '2.2.2' | |||
slf4jVersion = '1.7.30' | |||
slf4jVersion = '2.0.11' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move to 2.0.12, is the latest one
What does this PR do?
Adds support for EIP-4844
Where should the reviewer start?
Review all files
Why is it needed?
Closes #1979