Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sepolia network added #1971

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Sepolia network added #1971

merged 1 commit into from
Oct 4, 2023

Conversation

NickSneo
Copy link
Contributor

@NickSneo NickSneo commented Oct 4, 2023

What does this PR do?

Adds support for Sepolia network

Where should the reviewer start?

all files

Why is it needed?

Sepolia was't supported before
Resolves - #1928

@NickSneo NickSneo requested a review from conor10 as a code owner October 4, 2023 07:14
@NickSneo NickSneo requested a review from cfelde October 4, 2023 07:14
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1971 (878758f) into master (ac0618c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1971      +/-   ##
============================================
- Coverage     68.49%   68.48%   -0.02%     
+ Complexity     3004     3003       -1     
============================================
  Files           488      488              
  Lines         12559    12561       +2     
  Branches       1637     1638       +1     
============================================
  Hits           8602     8602              
- Misses         3482     3483       +1     
- Partials        475      476       +1     
Files Coverage Δ
core/src/main/java/org/web3j/ens/Contracts.java 76.92% <100.00%> (+4.19%) ⬆️
core/src/main/java/org/web3j/tx/ChainIdLong.java 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cfelde cfelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo NickSneo merged commit 6435c35 into master Oct 4, 2023
5 of 6 checks passed
@NickSneo NickSneo deleted the nicks/add-sepolia branch October 4, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants