Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx generateJavaFiles ArrayInStruct #1962

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

1329576606
Copy link
Contributor

What does this PR do?

FIx generateJavaFiles ArrayInStruct

Where should the reviewer start?

FIx generateJavaFiles ArrayInStruct

Why is it needed?

FIx generateJavaFiles ArrayInStruct

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1962 (18758b2) into master (e4e1dd7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1962      +/-   ##
============================================
+ Coverage     68.38%   68.40%   +0.02%     
- Complexity     2993     2994       +1     
============================================
  Files           488      488              
  Lines         12510    12519       +9     
  Branches       1631     1632       +1     
============================================
+ Hits           8555     8564       +9     
  Misses         3481     3481              
  Partials        474      474              
Files Changed Coverage Δ
...ava/org/web3j/codegen/SolidityFunctionWrapper.java 90.49% <100.00%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gtebrean
Copy link
Contributor

could you please add a test case?

@1329576606
Copy link
Contributor Author

could you please add a test case?

There was already a unit test and I perfected it.
See the changes to this file codegen/src/test/resources/solidity/arraysinstruct/build/java/ArraysInStruct.java

@1329576606
Copy link
Contributor Author

could you please add a test case?

There was already a unit test and I perfected it. See the changes to this file codegen/src/test/resources/solidity/arraysinstruct/build/java/ArraysInStruct.java

The unit test method is this:
codegen/src/test/java/org/web3j/codegen/SolidityFunctionWrapperGeneratorTest.java L:150 testArraysInStructCompareJavaFileTest()

Copy link
Contributor

@gtebrean gtebrean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as is better handling the Struct wrapper generation.

@gtebrean gtebrean merged commit e0b4b1e into hyperledger-web3j:master Sep 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants