Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StructuredDataEncoder.java #1918

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

vae520283995
Copy link
Contributor

Encode PrimitiveValue requires sha3

What does this PR do?

StructuredDataEncoder bug fix

Where should the reviewer start?

#1917

Why is it needed?

#1917

Encode PrimitiveValue requires sha3
@gtebrean gtebrean self-assigned this Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1918 (151d6aa) into master (61b3285) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master    #1918   +/-   ##
=========================================
  Coverage     68.13%   68.13%           
  Complexity     2985     2985           
=========================================
  Files           488      488           
  Lines         12501    12501           
  Branches       1627     1627           
=========================================
+ Hits           8517     8518    +1     
+ Misses         3509     3508    -1     
  Partials        475      475           
Files Changed Coverage Δ
...n/java/org/web3j/crypto/StructuredDataEncoder.java 89.77% <50.00%> (+0.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gtebrean gtebrean merged commit 1616b95 into hyperledger-web3j:master Aug 30, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants