Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blockHash filter to EthFilter due to EIP-234 #1292

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Add blockHash filter to EthFilter due to EIP-234 #1292

merged 2 commits into from
Nov 13, 2020

Conversation

JhChoy
Copy link
Contributor

@JhChoy JhChoy commented Nov 10, 2020 •
edited
Loading

What does this PR do?

  1. Add blockHash filter to EthFilter due to EIP-234.
  2. Fix test bug that actual and expected value were switched.

Where should the reviewer start?

  1. EthFilter => RequestTest
  2. RequestTester

Why is it needed?

  1. Support to query logs with blockHash which is described at eth_getLogs part of ethereum json wiki
  2. Test logs were confused.

@junbeomlee
Copy link

LGTM!

xaviarias
xaviarias reviewed Nov 13, 2020
View reviewed changes
core/src/main/java/org/web3j/protocol/core/methods/request/EthFilter.java
}

public EthFilter(String blockHash) {
super();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this super(); call is redundant.

xaviarias
xaviarias approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@xaviarias xaviarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@xaviarias xaviarias merged commit 266abcb into hyperledger-web3j:master Nov 13, 2020
rach-id pushed a commit to rach-id/web3j that referenced this pull request Dec 10, 2021
@JhChoy @rach-id
Add blockHash filter to EthFilter due to EIP-234 (hyperledger-web3j#1292
3311054 
)

* fix test bug that actual and expected value were switched

* add blockHash filter to EthFilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaviarias xaviarias xaviarias approved these changes

@conor10 conor10 Awaiting requested review from conor10

@iikirilov iikirilov Awaiting requested review from iikirilov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JhChoy @junbeomlee @xaviarias