Fix #919. Gen consistent privateKey with other eth libs #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawenpeng
changed the title
|
LGTM |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not stale |
|
This pull request has been mentioned on Web3 Labs Community. There might be relevant details there: https://community.web3labs.com/t/web3j-v4-8-0-released/112/1 |
rach-id
pushed a commit
to rach-id/web3j
that referenced
this pull request
Dec 10, 2021
…ibs (hyperledger-web3j#1259) * Fix hyperledger-web3j#919. Gen consistent privateKey with others. * Fix format issues. * Fix format issues with spotlessJavaApply Co-authored-by: mawenpeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #919 to generate consistent eth private keys with other eth libs by mnemonics.
Where should the reviewer start?
Please see the changes in the commit, and the comments of @razzbee in #919 .
Why is it needed?
Inconsistency makes imcompatibilities.