added check for private modiefiers

Signed-off-by: Nischal Sharma <[email protected]>
hyperledger-web3j · Apr 3, 2024 · 141f2aa · 141f2aa
1 parent c47ba3d
commit 141f2aa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/codegen/src/main/java/org/web3j/codegen/SolidityFunctionWrapper.java b/codegen/src/main/java/org/web3j/codegen/SolidityFunctionWrapper.java
@@ -672,7 +672,7 @@ private Set<String> getDuplicateFunctionNames(List<AbiDefinition> functionDefini
     private static MethodSpec buildGetDeploymentBinaryMethod() {
         MethodSpec.Builder toReturn =
                 MethodSpec.methodBuilder("getDeploymentBinary")
-                        .addModifiers(Modifier.PUBLIC, Modifier.STATIC)
+                        .addModifiers(Modifier.PRIVATE, Modifier.STATIC)
                         .returns(ClassName.get(String.class));
 
         CodeBlock codeBlock =

diff --git a/codegen/src/main/java/org/web3j/codegen/unit/gen/MethodFilter.java b/codegen/src/main/java/org/web3j/codegen/unit/gen/MethodFilter.java
@@ -13,6 +13,7 @@
 package org.web3j.codegen.unit.gen;
 
 import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -61,7 +62,7 @@ public static List<MethodSpec> generateMethodSpecsForEachTest(Class theContract)
                 .forEach(
                         method -> {
                             String uniqueName = getUniqueName(method, methodNameCountMap);
-                            if (!uniqueName.startsWith("getDeploymentBinary")) {
+                            if (!Modifier.isPrivate(method.getModifiers())) {
                                 listOfMethodSpecs.add(
                                         new MethodParser(method, theContract, uniqueName)
                                                 .getMethodSpec());
@@ -78,7 +79,7 @@ public static List<FunSpec> generateFunctionSpecsForEachTest(Class theContract)
                 .forEach(
                         method -> {
                             String uniqueName = getUniqueName(method, functionNameCountMap);
-                            if (!uniqueName.startsWith("getDeploymentBinary")) {
+                            if (!Modifier.isPrivate(method.getModifiers())) {
                                 listOfFunSpecs.add(
                                         new FunParser(method, theContract, uniqueName)
                                                 .getFunSpec());

diff --git a/codegen/src/test/resources/solidity/metacoin/build/java/MetaCoin.java b/codegen/src/test/resources/solidity/metacoin/build/java/MetaCoin.java
@@ -166,7 +166,7 @@ public static void linkLibraries(List<Contract.LinkReference> references) {
         librariesLinkedBinary = linkBinaryWithReferences(BINARY, references);
     }
 
-    public static String getDeploymentBinary() {
+    private static String getDeploymentBinary() {
         if (librariesLinkedBinary != null) {
             return librariesLinkedBinary;
         } else {