Online services integration #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfelde
reviewed
Mar 2, 2020
…r the request has been executed.
cfelde
reviewed
Mar 2, 2020
| @@ -77,6 +77,8 @@ public static void main(final CliConfig config, final String[] args) { | |||
| } else { | |||
| System.out.println("Account creation failed. Please try again later."); | |||
| } | |||
| client.connectionPool().evictAll(); | |||
There was a problem hiding this comment.
This is also needed elsewhere, but I'm not sure we're keeping the login?
Fixed unit tests failing when calling evict all in the mocked http client. Added more user friendly exception.
…ttp connection. Calling system exit due to okhttp thread hanging.
cfelde
reviewed
Mar 4, 2020
| @Override | ||
| public void close() throws IOException { | ||
| this.client.dispatcher().executorService().shutdown(); | ||
| this.client.connectionPool().evictAll(); |
There was a problem hiding this comment.
Do we need these two lines if we're calling System.exit(0) ?
Added null check and empty check on token error message. Change gradle settings to look at web3j master snapshot version. Reverted main gradle overwrite value to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for the upcoming online service integration.